Add validations for storage pickers #5619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inahK-2SO/StoragePickers_errorHandling
…inahK-2SO/StoragePickers_errorHandling
DinahK-2SO
requested review from
codendone,
yeelam-gordon and
Hong-Xiang
and removed request for
codendone
DinahK-2SO
force-pushed
the
user/DinahK-2SO/StoragePickers_errorHandling
branch
from
bc87f54 to
a18c73b
Compare
Hong-Xiang
reviewed
Jul 15, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
codendone
requested changes
Jul 17, 2025
| @@ -33,6 +33,7 @@ namespace winrt::Microsoft::Windows::Storage::Pickers::implementation | |||
| } | |||
| void FileSavePicker::SettingsIdentifier(hstring const& value) | |||
| { | |||
| PickerCommon::ValidateStringNoEmbeddedNulls(value); | |||
There was a problem hiding this comment.
Why do we care if there are embedded nulls? Same question for the Commit button text.
…inahK-2SO/StoragePickers_errorHandling
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
codendone
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several enhancements to the
StoragePickersinterop functionality, focusing on validation improvements, refactoring of file type management, and updates to thePickerLocationIdenumeration. The most significant changes include adding validation methods for picker properties, introducing new classes (FileTypeFilterVectorandFileTypeChoicesMap) to handle file type filtering with validation, and removing obsolete entries from thePickerLocationIdenumeration.Below validations for storage pickers are added:
Their resources can be seen in #5607
Details
Validation Enhancements
PickerCommon::ValidateViewMode,PickerCommon::ValidateStringNoEmbeddedNulls,PickerCommon::ValidateSuggestedStartLocation, andPickerCommon::ValidateSuggestedFileName) to ensure proper input values for picker properties acrossFileOpenPicker,FileSavePicker, andFolderPicker. These validations prevent invalid or malformed data from being set. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]File Type Management Refactor
FileTypeFilterVectorandFileTypeChoicesMapclasses to centralize file type filtering logic with validation. These classes ensure all file type elements are validated before being added or updated. [1] [2] [3] [4]FileOpenPickerandFileSavePickerconstructors to utilize these new classes for managing file type filters. [1] [2]PickerLocationId Updates
HomeGroup) from thePickerLocationIdenumeration and reassigned explicit values to remaining entries for consistency. [1] [2]Additional Improvements
Tests
Adding new tests:
Also verified with existing
StoragePickersTests